Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Application tray position drift #582

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Jul 23, 2024

Bind the location of the application tray

Issue: linuxdeepin/developer-center#9603

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link

deepin-bot bot commented Jul 23, 2024

TAG Bot

New tag: 0.0.29
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #572

Bind the location of the application tray

Issue: linuxdeepin/developer-center#9603
@18202781743
Copy link
Contributor

/forcemerge

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • ActionShowStashDelegate.qml中,itemGlobalPoint属性的计算方式可能会导致在窗口大小变化时出现精度问题。
  • tray.qml中,popupXpopupY的绑定被移除,这可能会影响弹出窗口的显示位置。
  • Component.onCompleted的逻辑在tray.qml中增加了对DockPanelPositioner.bounding的绑定,这可能会影响组件的布局和显示。
  • tray.qmlonActionsAlwaysVisibleChanged函数中,stashedPopup.open()stashedPopup.close()的逻辑被简化,可能会改变弹出窗口的显示和隐藏行为。

是否建议立即修改:

  • 需要确保ActionShowStashDelegate.qml中的itemGlobalPoint属性计算方式是准确和可靠的,以避免潜在的显示问题。
  • 需要验证移除popupXpopupY的绑定是否符合设计要求,并确保弹出窗口的显示位置是正确的。
  • 需要仔细检查Component.onCompleted的逻辑变化,确保组件的布局和显示仍然符合预期。
  • 需要确认tray.qmlonActionsAlwaysVisibleChanged函数的逻辑变化是否符合预期行为,特别是弹出窗口的显示和隐藏策略。

@deepin-bot
Copy link

deepin-bot bot commented Jul 23, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit e7e3a37 into linuxdeepin:master Jul 23, 2024
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants