Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Application preview background color overflow #580

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Jul 23, 2024

Background Alignment Preview Image

Issue: linuxdeepin/developer-center#9433

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link

deepin-bot bot commented Jul 23, 2024

TAG Bot

New tag: 0.0.29
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #572

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • painter->drawRoundedRect函数调用中,边距值QMargins(PREVIEW_HOVER_BORDER, PREVIEW_HOVER_BORDER, PREVIEW_HOVER_BORDER, PREVIEW_HOVER_BORDER)可能需要定义为常量,以避免在代码中多次硬编码相同的边距值。
  • 检查PREVIEW_HOVER_BORDER是否在代码的其他部分定义,以确保一致性和可维护性。

是否建议立即修改:

@18202781743
Copy link
Contributor

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Jul 23, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit d28485d into linuxdeepin:master Jul 23, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants