Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add margins to extend mouse area for tray item #579

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

18202781743
Copy link
Contributor

Tray item has margins for content, and it's set to loader.
Tray's model has stash data, and it's filter by itemVisible.
it depends on dde-tray-loader.

Issue: linuxdeepin/developer-center#9720

yixinshark
yixinshark previously approved these changes Jul 22, 2024
@deepin-bot
Copy link

deepin-bot bot commented Jul 23, 2024

TAG Bot

New tag: 0.0.29
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #572

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Tray item has margins for content, and it's set to loader.
Tray's model has stash data, and it's filter by itemVisible.
it depends on dde-tray-loader.

Issue: linuxdeepin/developer-center#9720
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • PluginSurface类中,margins属性的getter和setter方法被添加,但未看到对应的更新margin逻辑在send_margin函数中实现。
  • PluginSurface类中,margins属性的默认值被设置为0,但在setMargins方法中,如果新值与旧值相同,则不会发送更新信号。这可能会导致在某些情况下,margins的值不会被更新。
  • ActionLegacyTrayPluginDelegate组件中,itemVisible属性被添加,但未看到在组件显示/隐藏时更新该属性的逻辑。
  • StashedItemDelegateChooser组件中,stashItemPositionercontentItem属性被添加了itemVisible属性,但未看到在组件显示/隐藏时更新该属性的逻辑。
  • TrayItemDelegateChooser组件中,traySurfacePositionercontentItem属性被添加了itemVisible属性,但未看到在组件显示/隐藏时更新该属性的逻辑。
  • PanelTrayItem组件中,trayItemMargins属性被添加,但未看到在组件显示/隐藏时更新该属性的逻辑。

是否建议立即修改:

  • 确保PluginSurface类的margins属性的getter和setter方法中包含了更新margin逻辑,以确保send_margin函数正确处理margin更新。
  • 修改PluginSurface类的setMargins方法,以允许在margins值不同时才发送更新信号。
  • 确保ActionLegacyTrayPluginDelegate组件在显示/隐藏时正确更新itemVisible属性。
  • 确保StashedItemDelegateChooser组件在显示/隐藏时正确更新stashItemPositioner.contentItemitemVisible属性。
  • 确保TrayItemDelegateChooser组件在显示/隐藏时正确更新traySurfacePositioner.contentItemitemVisible属性。
  • 确保PanelTrayItem组件在显示/隐藏时正确更新trayItemMargins属性。

@18202781743
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Jul 23, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 229c242 into linuxdeepin:master Jul 23, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants