Skip to content

fix: layershell wrap bugs #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix: layershell wrap bugs #19

merged 1 commit into from
Nov 13, 2023

Conversation

tsic404
Copy link
Contributor

@tsic404 tsic404 commented Nov 10, 2023

  1. waylandSurafce not update after layershell perproty changed, because not commit changed, so now manually call waylandSurface()->commit()
  2. x11emulation not make window keep in center, can not get window size in qml before when init, but now connectted widthChanged and heightChanged.
  3. unable to anchor three sides, beacause wayland when setSize QSize::isEmpty get a unexpected result when width or height is 0, x11 not modify window size reason as above 2.

log: fix above bugs

@tsic404
Copy link
Contributor Author

tsic404 commented Nov 10, 2023

Fix: linuxdeepin/developer-center#6057

@tsic404 tsic404 requested a review from a team November 10, 2023 06:07
BLumia
BLumia reviewed Nov 10, 2023
View reviewed changes
@tsic404 tsic404 marked this pull request as draft November 10, 2023 06:36
@tsic404 tsic404 marked this pull request as ready for review November 10, 2023 06:43
@tsic404
fix: layershell wrap bugs
d015a41 
1. waylandSurafce not update after layershell perproty changed,
   because not commit changed, so now manually call waylandSurface()->commit()
2. x11emulation not make window keep in center, can not get window size in qml before when init,
   but now connectted widthChanged and heightChanged.
3. unable to anchor three sides, beacause
   wayland when setSize QSize::isEmpty get a unexpected result when width or height is 0,
   x11 not modify window size reason as above 2.

log: fix above bugs
@tsic404 tsic404 marked this pull request as draft November 10, 2023 06:51
@tsic404 tsic404 marked this pull request as ready for review November 10, 2023 06:53
@tsic404 tsic404 requested a review from BLumia November 10, 2023 07:34
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, Decodetalkers, tsic404

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tsic404 tsic404 merged commit 8ff6aca into linuxdeepin:master Nov 13, 2023
@tsic404 tsic404 deleted the layershell branch December 19, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@18202781743 18202781743 18202781743 approved these changes

@BLumia BLumia Awaiting requested review from BLumia

+1 more reviewer

@Decodetalkers Decodetalkers Decodetalkers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tsic404 @deepin-ci-robot @BLumia @18202781743 @Decodetalkers