feat: add translation of dde-shell plugin #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18202781743
reviewed
Apr 9, 2024
18202781743
reviewed
Apr 9, 2024
shell/appletloader.cpp
Outdated
| @@ -86,6 +100,9 @@ DAppletLoader::DAppletLoader(class DApplet *applet, QObject *parent) | |||
| { | |||
| D_D(DAppletLoader); | |||
| d->m_applet = applet; | |||
| connect(this, &DAppletLoader::failed, this, [d](const QString &pluginId) { | |||
| d->removeTranslation(pluginId); | |||
There was a problem hiding this comment.
这个对多实例的话,可能失败一个把所有的都卸载了,还不能这样卸载,
不卸载,或者在最后init完做个卸载的检查,
18202781743
approved these changes
Apr 9, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, yixinshark The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yixinshark
force-pushed
the
feat-ts
branch
3 times, most recently
from
be68f68
to
819417c
Compare
|
TAG Bot New tag: 0.0.7 |
Add translation of dde-shell plugin Log: add translation of dde-shell plugin Influence: translation
Add translation files Log: add translation files Influence: translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add translation of dde-shell plugin
Log: add translation of dde-shell plugin
Influence: translation