Skip to content

fix: use translated password prompt placeholder in AuthSingle #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhduiy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: use translated password prompt placeholder in AuthSingle #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/session-widgets/auth_single.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ void AuthSingle::initUI()
passwordLayout->addWidget(m_passwordHintBtn, 0, Qt::AlignRight | Qt::AlignVCenter);

mainLayout->addWidget(m_lineEdit);
setLineEditInfo(tr("Password"), PlaceHolderText);
updatePasswordTextMargins();
}

Expand Down Expand Up @@ -204,7 +205,7 @@ void AuthSingle::setAuthState(const AuthCommon::AuthState state, const QString &
setAnimationState(false);
m_lineEdit->setText(QString());
setLineEditEnabled(true);
setLineEditInfo(result, PlaceHolderText);
setLineEditInfo(tr("Password"), PlaceHolderText);
break;
case AS_Started:
break;
Expand Down
4 changes: 4 additions & 0 deletions translations/dde-session-shell_zh_CN.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,10 @@
</context>
<context>
<name>AuthSingle</name>
<message>
<source>Password</source>
<translation>请输入密码</translation>
Comment on lines +143 to +145

@sourcery-ai sourcery-ai Bot Sep 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: The new AuthSingle translation is added only to zh_CN; locale catalogs such as Japanese still have no AuthSingle/Password entry, so tr("Password") falls back to the English source text instead of using the localized password prompt that the equivalent AuthPassword context provides.

Triggers: When the greeter runs with a non-Chinese locale whose AuthSingle catalog lacks this newly introduced message.

Suggested fix: Add the AuthSingle/Password message to every maintained locale catalog, or regenerate the catalogs and provide the corresponding translations.

</message>
<message>
<source>Please try again 1 minute later</source>
<translation>请1分钟后再试</translation>
Expand Down
Loading