Skip to content

fix: fix variable shadowing in setInhibitorList icon name assignment - #103

Merged
Ivy233 merged 1 commit into
linuxdeepin:masterfrom
Ivy233:agent/developer/d49f20fdbf01
Nov 3, 2026
Merged

Ivy233 merged 1 commit into
linuxdeepin:masterfrom
Ivy233:agent/developer/d49f20fdbf01

Conversation

@Ivy233

@Ivy233 Ivy233 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

fix: 修复 setInhibitorList 中变量遮蔽导致图标名赋值无效

The inner QString iconName declaration shadowed the outer variable, causing the /proc//exe fallback to never update the iconName used by QIcon::fromTheme().

PMS: BUG-380633
Log: 修复 setInhibitorList 中变量遮蔽导致图标名赋值无效
Influence: 影响所有未注册 InhibitHint 接口的第三方应用图标显示

Summary by Sourcery

Bug Fixes:

  • Fix icon name resolution for third-party applications that fall back to their executable name when displaying inhibitor warnings.

@sourcery-ai

sourcery-ai Bot commented Oct 26, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Corrects variable shadowing in InhibitWarnView::setInhibitorList so third-party applications without registered InhibitHint icons can use their executable filename for theme icon lookup.

File-Level Changes

Change Details Files
Fix the fallback icon-name assignment so the executable filename updates the variable consumed by theme icon lookup.
  • Remove the inner local declaration and assign the executable filename to the existing icon-name variable.
  • Allow /proc//exe fallback icons to be resolved by QIcon::fromTheme().
src/widgets/inhibitwarnview.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

fix: 修复 setInhibitorList 中变量遮蔽导致图标名赋值无效

The inner QString iconName declaration shadowed the outer variable,
causing the /proc/<pid>/exe fallback to never update the iconName
used by QIcon::fromTheme().

PMS: BUG-380633
Log: 修复 setInhibitorList 中变量遮蔽导致图标名赋值无效
Influence: 影响所有未注册 InhibitHint 接口的第三方应用图标显示
@Ivy233
Ivy233 force-pushed the agent/developer/d49f20fdbf01 branch from 6dd715f to 9e5edad Compare October 26, 2026 08:40
deepin-ci-robot added a commit to linuxdeepin/dde-session-shell-snipe that referenced this pull request Oct 26, 2026
Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#103
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 100 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 本次提交修复了 setInhibitorList 函数中 iconName 变量的遮蔽(variable shadowing)问题,将局部重新声明改为对外层变量赋值,确保 QIcon::fromTheme 能正确使用更新后的图标名。变更仅 2 行(含版权年份更新),逻辑正确、影响范围极小,无安全漏洞,四维度均无问题。

🔍 详细分析

1. 语法逻辑 ✅

评价: 语法正确,逻辑清晰 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


2. 代码质量 ✅

评价: 代码结构清晰,注释完整 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


3. 代码性能 ✅

评价: 性能良好,资源使用合理 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


4. 代码安全 🔒

评价: 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: []


💡 改进建议代码示例


本报告由 AI 代码审查工具自动生成

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ivy233, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Ivy233 pushed a commit to linuxdeepin/dde-session-shell-snipe that referenced this pull request Nov 3, 2026
Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#103
@Ivy233
Ivy233 merged commit 08d5e07 into linuxdeepin:master Nov 3, 2026
14 of 15 checks passed
@Ivy233
Ivy233 deleted the agent/developer/d49f20fdbf01 branch November 3, 2026 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants