Repository navigation
fix: fix variable shadowing in setInhibitorList icon name assignment - #103
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideCorrects variable shadowing in InhibitWarnView::setInhibitorList so third-party applications without registered InhibitHint icons can use their executable filename for theme icon lookup. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
fix: 修复 setInhibitorList 中变量遮蔽导致图标名赋值无效 The inner QString iconName declaration shadowed the outer variable, causing the /proc/<pid>/exe fallback to never update the iconName used by QIcon::fromTheme(). PMS: BUG-380633 Log: 修复 setInhibitorList 中变量遮蔽导致图标名赋值无效 Influence: 影响所有未注册 InhibitHint 接口的第三方应用图标显示
Ivy233
force-pushed
the
agent/developer/d49f20fdbf01
branch
from
October 26, 2026 08:40
6dd715f to
9e5edad
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dde-session-shell-snipe
that referenced
this pull request
Oct 26, 2026
Synchronize source files from linuxdeepin/dde-session-shell. Source-pull-request: linuxdeepin/dde-session-shell#103
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: [] 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: [] 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: [] 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: [] 💡 改进建议代码示例本报告由 AI 代码审查工具自动生成 |
yixinshark
approved these changes
Oct 27, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ivy233, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Ivy233
pushed a commit
to linuxdeepin/dde-session-shell-snipe
that referenced
this pull request
Nov 3, 2026
Synchronize source files from linuxdeepin/dde-session-shell. Source-pull-request: linuxdeepin/dde-session-shell#103
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: 修复 setInhibitorList 中变量遮蔽导致图标名赋值无效
The inner QString iconName declaration shadowed the outer variable, causing the /proc//exe fallback to never update the iconName used by QIcon::fromTheme().
PMS: BUG-380633
Log: 修复 setInhibitorList 中变量遮蔽导致图标名赋值无效
Influence: 影响所有未注册 InhibitHint 接口的第三方应用图标显示
Summary by Sourcery
Bug Fixes: