Skip to content

Fix: handle filenames with spaces in kernbench script#1230

Closed
kumarsgoyal wants to merge 1 commit intolinux-test-project:masterfrom
kumarsgoyal:fix-cat-error-in-kernbench
Closed

Fix: handle filenames with spaces in kernbench script#1230
kumarsgoyal wants to merge 1 commit intolinux-test-project:masterfrom
kumarsgoyal:fix-cat-error-in-kernbench

Conversation

@kumarsgoyal
Copy link
Copy Markdown

Fix: handle filenames with spaces/newlines in kernbench source caching

This patch updates the loop used to cache the kernel source into RAM to handle filenames with spaces, newlines, and other special characters correctly.

Previously, the script used a for loop over backtick-evaluated find, which would break on filenames with spaces or unusual characters. This caused warnings like:

cat: ./tools/testing/selftests/devices/probe/boards/Dell: No such file or directory
cat: Inc.,XPS: No such file or directory

This patch replaces the loop with a more robust find . -type f -print0 | while IFS= read -r -d '' structure, which safely handles all valid filenames.

Signed-off-by: Sahil Kumar kumar.sgoyal@gmail.com

@metan-ucw
Copy link
Copy Markdown
Member

Hi! The change looks fine however there are spaces before tabs that should be fixed and the commit is missing signed-off-by line, see https://gerrit-review.googlesource.com/Documentation/user-signedoffby.html

@kumarsgoyal
Copy link
Copy Markdown
Author

Closing this PR as it has been superseded by a newer one.

Please refer to the updated PR here: #1299

@kumarsgoyal
Copy link
Copy Markdown
Author

Closing this PR as it has been superseded by a newer one.

Please refer to the updated PR here: #1299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants