ci: do not run ci tests by default, require citest comment or label - #186
ci: do not run ci tests by default, require citest comment or label#186richm wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
spetrosi
left a comment
There was a problem hiding this comment.
lgtm, so only act on comments because Labels cannot be implemented due to GitHub limitations?
Correct. I've been looking at the permissions for the label triggers for ci:
However, since method 1) is only a problem for org admins, I think it might be worth it to add support for labels for individual repo contributors and admins as a convenience. I'll take a look at this. |
71a2449 to
41e1d20
Compare
41e1d20 to
7d487ac
Compare
…citest_skip] github action ci jobs are a precious resource - we only have 20 jobs - when multiple PRs are submitted we may have to wait hours to get results. We need to be explicit about where and when to run ci jobs. With this change, when a PR is created or updated, CI tests will not run automatically. A role maintainer (OWNER, MEMBER, COLLABORATOR, or systemroller) must either comment on the PR or add a label: * `[citest_all]` comment or `citest_all` label - run all CI tests, including checks and Testing Farm integration tests * `[citest_$test]` comment or `citest_$test` label - run only that test - for example, `[citest_ansible-lint]` or the `citest_ansible-lint` label * For Testing Farm, `[citest_tft]` / `citest_tft` runs those tests. `[citest]` / `citest` is still accepted for Testing Farm for backward compatibility. Comments work on issue_comment; labels take effect when the PR is opened, when new commits are pushed, or when the label is added. These labels are created in each role repo by the update_files playbook. If you use the `gh` command to interact with github, you can use `gh pr comment $PRNUM -b '[citest_all]'` or `gh pr edit $PRNUM --add-label citest_all` Signed-off-by: Rich Megginson <rmeggins@redhat.com>
github action ci jobs are a precious resource - we only have 20 jobs - when multiple
PRs are submitted we may have to wait hours to get results. We need to be explicit
about where and when to run ci jobs.
With this change, when a PR is created or updated, CI tests will not run automatically.
A role maintainer (OWNER, MEMBER, COLLABORATOR, or systemroller) must either comment
on the PR or add a label:
[citest_all]comment orcitest_alllabel - run all CI tests, including checksand Testing Farm integration tests
[citest_$test]comment orcitest_$testlabel - run only that test - forexample,
[citest_ansible-lint]or thecitest_ansible-lintlabel[citest_tft]/citest_tftruns those tests.[citest]/citestis still accepted for Testing Farm for backward compatibility.Comments work on issue_comment; labels take effect when the PR is opened, when new
commits are pushed, or when the label is added. These labels are managed by
system roles .github automation.
If you use the
ghcommand to interact with github, you can usegh pr comment $PRNUM -b '[citest_all]'or
gh pr edit $PRNUM --add-label citest_allSigned-off-by: Rich Megginson rmeggins@redhat.com