Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize folder structure, improve build procedure #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

semlanik
Copy link

Hi,
I improved build procedure, without using any autotools etc.
In README there are build insturctions

@amery
Copy link
Member

amery commented Nov 27, 2014

I like the overall idea but somehow the "binaries" feels wrong.... maybe "baremetal" fits better?

@semlanik
Copy link
Author

I tried to find good one name for this :) Going to rename.

semlanik pushed a commit to semlanik/sunxi-tools that referenced this pull request Nov 27, 2014
@semlanik
Copy link
Author

@oliv3r sorry, my mistake, I just copy-paste header from file to file.

@amery
Copy link
Member

amery commented Nov 27, 2014

@semlanik: to keep the merge clean, can you squash the fixes into the corresponding commits?

@semlanik
Copy link
Author

@amery, done.

@semlanik semlanik force-pushed the master branch 3 times, most recently from b6870e6 to 18ff793 Compare November 27, 2014 14:22
@semlanik
Copy link
Author

I updated installation rules to support prefixes

@semlanik semlanik force-pushed the master branch 2 times, most recently from 4a1e54d to 21e6bf7 Compare November 27, 2014 22:32
@semlanik
Copy link
Author

Hi,
will you merge reworked build procedure to master or probably you have some ideas etc. for this?

Regards,
Alexey.

@amery
Copy link
Member

amery commented Nov 29, 2014

I'm actually waiting for other people to comment....

@amery
Copy link
Member

amery commented Dec 1, 2014

@libv, @turl, @hno: anything to comment?

nand-part
meminfo
*.o
*.swp
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these dropped? Won't binaries / .o start showing on git status now?

@turl
Copy link

turl commented Dec 1, 2014

Those are some small comments from having a quick look at it, I haven't tested it yet but it looks promising 👍

@semlanik
Copy link
Author

semlanik commented Dec 1, 2014

Hi, thanks! Will fix comments ASAP.

Regards,
Alexey.

@semlanik
Copy link
Author

semlanik commented Dec 1, 2014

Done

@amery
Copy link
Member

amery commented Dec 1, 2014

you destroyed the intermediate changes :-\ this made sense in 3 commits.

also, git diff -M origin/master.. shows a couple of \ No newline at end of file, empty new lines at the bottom and trailing whitespace.

@amery
Copy link
Member

amery commented Dec 1, 2014

@semlanik: the default target is also wrong... make should build more that just bootinfo.

@semlanik
Copy link
Author

semlanik commented Dec 1, 2014

Sorry for history, I will rebase branch once you will give "green lite".

Use empty default prefix
@semlanik
Copy link
Author

semlanik commented Dec 1, 2014

@amery Argh, I'm sorry so much. Looks like I removed huge part of comments. I'm idiot....
Regarding CFLAGS, it's just to keep original CFLAGS that was in project. that's why CFLAGS ?= -O0
Regarding PREFIX and CHOST I removed it.

@semlanik
Copy link
Author

Hi guys,
sorry for my molestation any updates, comments?

@oliv3r
Copy link
Member

oliv3r commented Dec 23, 2014

Overal it looks good; needs some testing though?

@ssvb
Copy link
Contributor

ssvb commented Nov 6, 2017

This old pull request did not seem to have moved anywhere and now even can't be applied to the current git. Should we just close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants