Merged
Conversation
hreinecke
force-pushed
the
fabric_args
branch
2 times, most recently
from
053cdb6 to
33b4925
Compare
First step towards removal of fabric_args. Signed-off-by: Hannes Reinecke <hare@suse.de>
All information is stored in nvmf_context, so use that instead. Signed-off-by: Hannes Reinecke <hare@suse.de>
Remove the final references to 'fabric_args' and remove the structure. Signed-off-by: Hannes Reinecke <hare@suse.de>
Unused. Signed-off-by: Hannes Reinecke <hare@suse.de>
Collaborator
|
Thanks a lot for taking the time to cleanup the mess I did! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'struct fabric_args' is just an intermediate structure to hold information for creating a controller. Which is really pointless, as 'struct nvmf_context' is serving exactly the same purpose. So this patchset first ensures that any lookup / scan / create will always run on a local copy of 'struct nvmf_context', as then 'struct fabric_args' can be dropped.