Skip to content

Add Statistics Identifier String Table Size to OCP Telemetry String Log JSON Output#3164

Merged
igaw merged 1 commit intolinux-nvme:masterfrom
sfindley102892:master
Mar 11, 2026
Merged

Add Statistics Identifier String Table Size to OCP Telemetry String Log JSON Output#3164
igaw merged 1 commit intolinux-nvme:masterfrom
sfindley102892:master

Conversation

@sfindley102892
Copy link
Copy Markdown
Contributor

Statistics Identifier String Table Size is missing from the output of telemetry-string-log command JSON so I added it in plugins/ocp/ocp-print-json.c.

Example snippet from local telemetry-string-log output:

  "Statistics Identifier String Table Start":108,
  "Statistics Identifier String Table Size":400,
  "Event String Table Start":508,

@sfindley102892 sfindley102892 changed the title Add Statistics Identifier String Table Size to Telemetry String Log JSON Output Add Statistics Identifier String Table Size to OCP Telemetry String Log JSON Output Mar 10, 2026
@igaw
Copy link
Copy Markdown
Collaborator

igaw commented Mar 11, 2026

Looks good. I would update the commit message slightly. And can I have your Signed-off-by tag?

ocp: add Statistics Identifier String Table Size to JSON

The Statistic Identifier String Table Size is missing in the JSON
output, add it.

Signed-off-by: Shaneal Findley <x@y.z>

Thanks

The Statistic Identifier String Table Size is missing in the JSON
output, added it.

Signed-off-by: Shaneal Findley <shaneal.findley@solidigm.com>
@sfindley102892
Copy link
Copy Markdown
Contributor Author

Thanks @igaw I renamed the commit. Should be good now.

@igaw igaw merged commit e89daf6 into linux-nvme:master Mar 11, 2026
24 of 25 checks passed
@igaw
Copy link
Copy Markdown
Collaborator

igaw commented Mar 11, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants