Sndk plugin fixes

[jeff-lien-sndk]

This PR contains fixes or changes for the following issues:

• Add Support for SN655 UUID checking in sandisk plugin
• Add Clear Assert Capability for new drives
• vs-internal-log Sandisk plugin command does not set data area value correctly
• Updates to vs-internal-log plugin command

[igaw]

there is a build error:

 gcc -Invme.p -I. -I.. -Iccan -I../ccan -Ilibnvme/src -I../libnvme/src -I/usr/include/json-c -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -std=gnu99 -O0 -g -fomit-frame-pointer -D_GNU_SOURCE -include /__w/nvme-cli/nvme-cli/.build-ci/nvme-config.h -DCCAN_LIST_DEBUG=1 -DCCAN_STR_DEBUG=1 -MD -MQ nvme.p/plugins_sandisk_sandisk-nvme.c.o -MF nvme.p/plugins_sandisk_sandisk-nvme.c.o.d -o nvme.p/plugins_sandisk_sandisk-nvme.c.o -c ../plugins/sandisk/sandisk-nvme.c
../plugins/sandisk/sandisk-nvme.c: In function ‘sndk_vs_internal_fw_log’:
../plugins/sandisk/sandisk-nvme.c:542:65: error: ‘.tar’ directive output may be truncated writing 4 bytes into a region of size between 1 and 4096 [-Werror=format-truncation=]
  542 |                                 snprintf(tar_file, PATH_MAX, "%s.tar", f);
      |                                                                 ^~~~
../plugins/sandisk/sandisk-nvme.c:542:33: note: ‘snprintf’ output between 5 and 4100 bytes into a destination of size 4096
  542 |                                 snprintf(tar_file, PATH_MAX, "%s.tar", f);
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

rest looks good.

[jeff-lien-sndk]

there is a build error:

 gcc -Invme.p -I. -I.. -Iccan -I../ccan -Ilibnvme/src -I../libnvme/src -I/usr/include/json-c -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -std=gnu99 -O0 -g -fomit-frame-pointer -D_GNU_SOURCE -include /__w/nvme-cli/nvme-cli/.build-ci/nvme-config.h -DCCAN_LIST_DEBUG=1 -DCCAN_STR_DEBUG=1 -MD -MQ nvme.p/plugins_sandisk_sandisk-nvme.c.o -MF nvme.p/plugins_sandisk_sandisk-nvme.c.o.d -o nvme.p/plugins_sandisk_sandisk-nvme.c.o -c ../plugins/sandisk/sandisk-nvme.c
../plugins/sandisk/sandisk-nvme.c: In function ‘sndk_vs_internal_fw_log’:
../plugins/sandisk/sandisk-nvme.c:542:65: error: ‘.tar’ directive output may be truncated writing 4 bytes into a region of size between 1 and 4096 [-Werror=format-truncation=]
  542 |                                 snprintf(tar_file, PATH_MAX, "%s.tar", f);
      |                                                                 ^~~~
../plugins/sandisk/sandisk-nvme.c:542:33: note: ‘snprintf’ output between 5 and 4100 bytes into a destination of size 4096
  542 |                                 snprintf(tar_file, PATH_MAX, "%s.tar", f);
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

rest looks good.

there is a build error:

 gcc -Invme.p -I. -I.. -Iccan -I../ccan -Ilibnvme/src -I../libnvme/src -I/usr/include/json-c -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -std=gnu99 -O0 -g -fomit-frame-pointer -D_GNU_SOURCE -include /__w/nvme-cli/nvme-cli/.build-ci/nvme-config.h -DCCAN_LIST_DEBUG=1 -DCCAN_STR_DEBUG=1 -MD -MQ nvme.p/plugins_sandisk_sandisk-nvme.c.o -MF nvme.p/plugins_sandisk_sandisk-nvme.c.o.d -o nvme.p/plugins_sandisk_sandisk-nvme.c.o -c ../plugins/sandisk/sandisk-nvme.c
../plugins/sandisk/sandisk-nvme.c: In function ‘sndk_vs_internal_fw_log’:
../plugins/sandisk/sandisk-nvme.c:542:65: error: ‘.tar’ directive output may be truncated writing 4 bytes into a region of size between 1 and 4096 [-Werror=format-truncation=]
  542 |                                 snprintf(tar_file, PATH_MAX, "%s.tar", f);
      |                                                                 ^~~~
../plugins/sandisk/sandisk-nvme.c:542:33: note: ‘snprintf’ output between 5 and 4100 bytes into a destination of size 4096
  542 |                                 snprintf(tar_file, PATH_MAX, "%s.tar", f);
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

rest looks good.

@igaw Fixed now. Sorry I missed this error.

[igaw]

No worries, happens :)

I squashed the fixup patch into the last one, which broke the build. The goal is that every commit builds. Helps in cased someone bissects the tree.

[igaw]

Thanks!

[jeff-lien-sndk]

@igaw Do you have plans to create and release the 3.0 version soon? I have a few users asking when the next official release/tag will be available.

[igaw]

There is still a bit of API review to do before the 3.0 release. The main goal is to get the libnvme API sorted out, so we don't have the same issue as with the 1.0 release.

What we could do is some beta releases if this would help. The only thing I don't want to guarantee is a stable API.

[jeff-lien-sndk]

beta releases might be a good temporary solution. Thanks.