Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: assign-collaboration: Fix typo #393

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Documentation: assign-collaboration: Fix typo #393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Documentation/teaching/so2/assign-collaboration.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ Follow the seven rules of writing a good commit message: https://cbea.ms/git-com
Add `TODOs` with each team member tasks. Try to split the work evenly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanyujie2002 for next patches can you please also your Signed-off-by line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanyujie2002 for next patches can you please also your Signed-off-by line?

Sorry, the Linux repo is too huge, which causes me finding myself reluctant to clone this repo on my personal computer. So I make commits directly on GitHub, which makes signing-off impossible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, when you create commit directly on github isn;t possible to add by hand:

Signed-off-by: First Name Last Name

in your commit message?

This sounds strange.

How do you add the commit subject then?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On, I see. Thanks for your instruction. 👍

Before starting to code, make a plan. On top of your skeleton file, add TODOs with each member tasks. Agree on global
structures and the overlall driver design. Then start coding.
structures and the overall driver design. Then start coding.

5. Do reviews
-------------
Expand Down
Loading