Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(commons): migrate to newest async library #256

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Conversation

linrongbin16
Copy link
Owner

@linrongbin16 linrongbin16 commented Nov 25, 2024

Regression Test

Platforms

  • windows
  • macOS
  • linux

Hosts

Functions

  • Use GitLink(!) to copy git link (or open in browser).
  • Use GitLink(!) blame to copy the /blame link (or open in browser).
  • Use GitLink(!) default_branch to open the /main//master link in browser (or open in browser).
  • Use GitLink(!) current_branch to open the current branch link in browser (or open in browser).
  • Copy git link in a symlink directory of git repo.
  • Copy git link in an un-pushed git branch, and receive an expected error.
  • Copy git link in a pushed git branch but edited file, and receive a warning says the git link could be wrong.
  • Copy git link with 'file' and 'rev' parameters.

@linrongbin16 linrongbin16 merged commit f643cdf into master Nov 25, 2024
6 checks passed
@linrongbin16 linrongbin16 deleted the async branch November 25, 2024 02:14
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.43%. Comparing base (8e193f0) to head (f76166b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lua/gitlinker.lua 66.66% 2 Missing ⚠️
lua/gitlinker/linker.lua 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   70.40%   74.43%   +4.03%     
==========================================
  Files          10        9       -1     
  Lines         963      845     -118     
==========================================
- Hits          678      629      -49     
+ Misses        285      216      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant