upcoming: [UIE 9401] – Implement Share Groups Landing page tabs#13471
Open
fabrice-akamai wants to merge 9 commits intolinode:developfrom
Open
upcoming: [UIE 9401] – Implement Share Groups Landing page tabs#13471fabrice-akamai wants to merge 9 commits intolinode:developfrom
fabrice-akamai wants to merge 9 commits intolinode:developfrom
Conversation
Collaborator
Cloud Manager UI test results🔺 4 failing tests on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/parentChild/account-switching.spec.ts" |
||||||||||||||||||||||||||
pmakode-akamai
approved these changes
Mar 9, 2026
Contributor
pmakode-akamai
left a comment
There was a problem hiding this comment.
thanks @fabrice-akamai! This looks good to me 👍 Could we also add a Upcoming Features changeset for this PR?
| @@ -95,29 +95,29 @@ describe('useIsPrivateImageSharingEnabled', () => { | |||
| }); | |||
|
|
|||
| describe('getImageLibrarySubTabIndex', () => { | |||
Contributor
There was a problem hiding this comment.
Suggested change
| describe('getImageLibrarySubTabIndex', () => { | |
| describe('getSubTabIndex', () => { |
| import { createRoute, redirect } from '@tanstack/react-router'; | ||
|
|
||
| import { imageLibrarySubTabs } from 'src/features/Images/ImagesLanding/v2/ImageLibrary/imageLibraryTabsConfig'; | ||
| import { shareGroupsSubTabs } from 'src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsTabsConfig'; |
Contributor
There was a problem hiding this comment.
Suggested change
| import { shareGroupsSubTabs } from 'src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsTabsConfig'; | |
| import { shareGroupsSubTabs } from 'src/features/Images/ImagesLanding/v2/ShareGroups/shareGroupsTabsConfig'; |
Could we rename either ShareGroupsTabsConfig to shareGroupsTabsConfig or imageLibraryTabsConfig to ImageLibraryTabsConfig for naming consistency?
| Membership Requests is coming soon... | ||
| </Notice> | ||
| )} | ||
| </SafeTabPanel> |
Contributor
There was a problem hiding this comment.
Why are we not using routed tabs here? See other examples with lazy routes + Outlet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR implements the Share Groups Landing page and its corresponding subtabs:
This feature builds upon the existing work on the Image Library tabs and lays the groundwork for the Share groups implementation under the
isPrivateImageSharingEnablefeature flag.Changes 🔄
List any change(s) relevant to the reviewer.
ShareGroupsTabs.tsxandShareGroupsTabsConfig.tsxgetImageLibrarySubTabIndexto be more generic so the Share Groups tab can reuse the same logicShareGroupsTabs.tsxScope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
isPrivateImageSharingEnabledis enabled for testing the feature under the newImagespageReproduction steps
Verification steps
(How to verify changes)
localhost:3000/images/Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅