Skip to content

fix: Fix backups bug for Linode Interfaces#13458

Merged
coliu-akamai merged 4 commits intolinode:developfrom
coliu-akamai:linode-backups-bug
Mar 10, 2026
Merged

fix: Fix backups bug for Linode Interfaces#13458
coliu-akamai merged 4 commits intolinode:developfrom
coliu-akamai:linode-backups-bug

Conversation

@coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Mar 3, 2026

Description 📝

The Network Connection selection field is incorrectly disabled on the backups page. It should only be disabled if interface type is Configuration Profile Interfaces

Changes 🔄

  • keep previous interface generation type when selecting a Linode on the backups page
    • (we don't want to use linode.interface_generation for here because the selected linode might have a different interface generation type than what's allowed by our account setting )
  • Hide VLAN/VPC interface fields if unable to select Network Connection type + clear vpc/vlan fields in case they were already touched when selecting Config profile on backups tab to prevent hidden errors
  • moved up logic to disable Interface Type, since I'm also using this to determine when to hide VLAN/VPC stuff

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers (I think?)
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

next release?

Preview 📷

Before After
linode-backups-behavior.mov
linode-backups-updated-behavior.mov

How to test 🧪

Prerequisites

Have a Linode that has a backup

Reproduction steps

For all account setting options except for Configuration Profile Interface only:

  • Navigate to the the Create Linode from Backups page. Before selecting a Linode, note the interface generation type is correct (linode)
  • Select a Linode with a backup - notice how interface generation type becomes undefined
  • Networking Connection type is disabled (even though selected interface type is Linode in the UI, underlying value is undefined)

For an account setting with Configuration Profile Interface only:

  • Navigate to the the Create Linode from Backups page. Before selecting a Linode, note the interface generation type is correct (legacy_config)
  • Select a Linode with a backup - notice how interface generation type becomes undefined
  • Networking Connection type is disabled but
  • Network Interface type is incorrectly set to Linode even though it should be Configuration Profiles - this is because if interface generation type is undefined, Linode is now always chosen

Verification steps

  • Confirm when you select a Linode from the Backups table, the Interface Generation type is what you'd expect
    • Configuration Profile Interfaces for 'Configuration Profile Interface only' account setting
    • Linode Interfaces for all other Account setting options
  • and that the Interface Type is only disabled when Interface Generation is 'Configuration Profile'
  • Confirm that creating a Linode in the other flows (os, stackscript, etc) still works fine
  • Confirm that cloning a Linode still works fine

@coliu-akamai coliu-akamai self-assigned this Mar 3, 2026
@coliu-akamai coliu-akamai changed the title Fix backups bug for Linode Interfaces fix: Fix backups bug for Linode Interfaces Mar 3, 2026
@coliu-akamai coliu-akamai added the Linodes Dealing with the Linodes section of the app label Mar 3, 2026
@coliu-akamai coliu-akamai marked this pull request as ready for review March 3, 2026 21:48
@coliu-akamai coliu-akamai requested a review from a team as a code owner March 3, 2026 21:48
Copy link
Contributor

@grevanak-akamai grevanak-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coliu-akamai for noticing this bug. Changes looks good and verified that this has fixed the bug and no regression impact after the changes.

@grevanak-akamai
Copy link
Contributor

grevanak-akamai commented Mar 10, 2026

@bnussman-akamai, can you review this PR? Linode interface GA release is targeted in this month and this PR is fixing a bug related to this feature.

@grevanak-akamai grevanak-akamai added the Add'tl Approval Needed Waiting on another approval! label Mar 10, 2026
@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Mar 10, 2026
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Mar 10, 2026
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing877 Passing11 Skipped39m 27s

Details

Failing Tests
SpecTest
object-storage.e2e.spec.tsCloud Manager Cypress Tests→object storage end-to-end tests » can create and delete object storage buckets

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts"

@coliu-akamai coliu-akamai merged commit 0042755 into linode:develop Mar 10, 2026
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Mar 10, 2026
@coliu-akamai coliu-akamai deleted the linode-backups-bug branch March 10, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Linode Interfaces Linodes Dealing with the Linodes section of the app

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

4 participants