WIP: API docs for LKE NodePool labels and taints #953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrogers950
changed the title
|
Just tagging as WIP for now to ensure we don't merge before the feature |
mrogers950
commented
May 29, 2024
| type: string | ||
| minLength: 1 | ||
| maxLength: 63 | ||
| pattern: '^([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]${1,63}' |
There was a problem hiding this comment.
note for reviewers: I'm not sure about including the pattern as it's specified because it doesn't take into account the third bullet point in the description below, which changes the length and allowed pattern on the prefix.
There was a problem hiding this comment.
The syntax {1,63} placed after $, I'm not sure that's correct..
Can I remove ${1,63} from the syntax?
mrogers950
force-pushed
the
nodepool_labels_taints_apidoc
branch
from
b233e1a
to
dfd35dd
Compare
|
Closing this in favor of #954 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds docs for the upcoming LKE API feature of adding Kubernetes labels and taints to node pools.