Add support for DNS and only create instances that do not exist #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need linode-api4 5.29 to assign firewalls to newly created linodes.
We can assign a firewall to newly created linodes if the user sets a firewall_label in `vars`
Add the firewall_label variable to vars that allows setting a firewall when deploying linodes
Use the rdns name for the linode rather than the IP when doing ssh since this allows corporate DNS servers to reroute traffic through their own proxies.
|
Any chance of having this merged? |
If a `domain_name` is configured in `vars`, then we should also add these hosts to DNS. Before adding, we will remove any stale records. The hostname in `kafka_data` is used to generate self signed certificates. If we're using a FQDN name to connect to kafka, then the certificate needs to have this FQDN as well.
…nce.label for everything else
This commit checks which kafka instances have already been created before trying to create new ones. It will only create instances that do not already exist. instance_list gets us information about all instances in a single call which is more efficient than looping through instance_info just to check if an instance has been created.
…iously created cluster id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for updating linode DNS with entries for the newly created kafka hosts.
It also checks that a host hasn't already been created before creating new hosts. This allows you to (for example), delete one linode from the cluster, and then run the playbooks to just recreate that one host.
Additionally, we now use
rdnsinstead of IPs to ssh into the host. This is necessary because some corporate DNS systems (like at Akamai) require some hosts (like linode) to go through a proxy server that is allowed by their default firewall rules (see PR #8 for firewall support), and without this, the wait_for task would just timeout.Note that this PR builds on #8 so it includes all commits from that PR as well.