Let assertEquals be strict assertSame #5

peter279k · 2023-09-18T10:32:09Z

Changed log

Let assetEquals be strict assertSame.
According the PHPUnit changedlog, it should remove the --verbose option.

peter279k · 2023-09-18T10:34:43Z

tests/Linna/Http/Message/UriTest.php

@@ -146,7 +146,7 @@ public function portProvider(): array
     */
    public function testGetPort(string $scheme, string $port, int $expected): void
    {
-        $this->assertEquals($expected, (new Uri("{$scheme}://username:[email protected]{$port}/path?arg=value#anchor"))->getPort());
+        $this->assertSame($expected, (int)(new Uri("{$scheme}://username:[email protected]{$port}/path?arg=value#anchor"))->getPort());


In the data providers, the set#0 and set#4 will return null when calling the Uri::getPort method.

It should casting the null to be 0 when asserting the above two test data.

peter279k commented Sep 18, 2023

View reviewed changes

Let assertEquals be strict assertSame

84160fc

peter279k force-pushed the improve_assertion branch from de35d43 to 84160fc Compare September 18, 2023 10:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Let assertEquals be strict assertSame #5

Let assertEquals be strict assertSame #5

peter279k commented Sep 18, 2023 •

edited

Loading

peter279k Sep 18, 2023

Let assertEquals be strict assertSame #5

Are you sure you want to change the base?

Let assertEquals be strict assertSame #5

Conversation

peter279k commented Sep 18, 2023 • edited Loading

Changed log

peter279k Sep 18, 2023

Choose a reason for hiding this comment

peter279k commented Sep 18, 2023 •

edited

Loading