[dvc] Fix metrics reporting issue for DVRT and add more metrics #1548

kvargha · 2025-02-21T21:40:46Z

[dvc] Fix metrics reporting issue for DVRT and add more metrics

Fixed an issue where the metrics for DVRT were being registered, but they weren't being emitted.
Added more metrics for DVRT to cover more operations for better visibility.
Removed unnecessary integration test steps for DVRT to speed up CI.

How was this PR tested?

Added unit and integration tests

Does this PR introduce any user-facing changes?

No. You can skip the rest of this section.
Yes. Make sure to explain your proposed changes and call out the behavior change.

internal/venice-client-common/src/main/java/com/linkedin/venice/utils/LatencyUtils.java

...ice-test-common/src/integrationTest/java/com/linkedin/venice/endToEnd/DaVinciClientTest.java

...ient/src/main/java/com/linkedin/davinci/stats/AggVersionedDaVinciRecordTransformerStats.java

.../da-vinci-client/src/main/java/com/linkedin/davinci/stats/DaVinciRecordTransformerStats.java

...i-client/src/main/java/com/linkedin/davinci/stats/DaVinciRecordTransformerStatsReporter.java

kvargha and others added 9 commits February 14, 2025 14:55

Fix bug in DVRT where metrics weren't being emitted

4e80507

Add unit tests

87b76c5

Fix unit test

da216e3

fix spotbugs

162adc3

Merge branch 'linkedin:main' into dvrt_metrics

ac73362

Add metric for tracking delete error count and fix latency calculation

626ef23

Remove unused function

babb331

Fix unit metric reporting

e56acc4

Make function names consistent

4f7869a

kvargha changed the title ~~[dvc] Fixed metrics reporting issue for DVRT and added more metrics~~ [dvc] Fix metrics reporting issue for DVRT and added more metrics Feb 22, 2025

kvargha changed the title ~~[dvc] Fix metrics reporting issue for DVRT and added more metrics~~ [dvc] Fix metrics reporting issue for DVRT and add more metrics Feb 22, 2025

Distinguish between units

59c3124

KaiSernLim reviewed Feb 24, 2025

View reviewed changes

Address review comments

5e3342c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dvc] Fix metrics reporting issue for DVRT and add more metrics #1548

[dvc] Fix metrics reporting issue for DVRT and add more metrics #1548

kvargha commented Feb 21, 2025 •

edited

Loading

[dvc] Fix metrics reporting issue for DVRT and add more metrics #1548

Are you sure you want to change the base?

[dvc] Fix metrics reporting issue for DVRT and add more metrics #1548

Conversation

kvargha commented Feb 21, 2025 • edited Loading