[server] Use correct offset when non-agg leader is resubscribing for workload change action #1547
+192
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…workload change action
sushantmane
reviewed
Feb 21, 2025
...ient/src/main/java/com/linkedin/davinci/kafka/consumer/LeaderFollowerStoreIngestionTask.java
Outdated
Show resolved
Hide resolved
sushantmane
reviewed
Feb 24, 2025
...ient/src/main/java/com/linkedin/davinci/kafka/consumer/LeaderFollowerStoreIngestionTask.java
Outdated
Show resolved
Hide resolved
sushantmane
previously approved these changes
Feb 24, 2025
sushantmane
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[server] Use correct offset when non-agg leader is resubscribing for workload change action
In Non-Aggregate mode, we reserve special keyword for upstream offset map. During resubscribe as leader action, current code does not look for correct key in the map, and resubscribe to the beginning of the RT topic during pool jump. This will result in a spike in leader HB delay, and a lot of duplicate messages (skipped).
This PR fixes it by using the correct key for upstream offset based on SIT mode.
How was this PR tested?
Added new unit test and integration test to cover this fix.
Does this PR introduce any user-facing changes?