[server][vpj][controller] Remove Kafka serialization classes and improve producer flexibility #1538
+707
−417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of
org.apache.kafka.common.serialization
classes and update producer for easier parameter additionChanges:
Kafka Producer Adapter Enhancements
create
method and introduced a new defaultcreate
method inPubSubProducerAdapterFactory.java
usingPubSubProducerAdapterContext
.ApacheKafkaProducerAdapter
to usebyte[]
for keys and values instead ofKafkaKey
andKafkaMessageEnvelope
.sendMessage
method to improve flexibility.ApacheKafkaProducerConfig
to includePubSubMessageSerializer
and set serializer configurations for Kafka producer.Configuration Management Improvements
getPubSubConsumerProperties
inDumpAdminMessages.java
.PubSubConstants.java
to usePUBSUB_CLIENT_CONFIG_PREFIX
.Code Cleanup
SharedKafkaProducerConfig
as it is no longer needed.How was this PR tested?
Does this PR introduce any user-facing changes?