Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support uncompressed event logs #357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support uncompressed event logs #357

wants to merge 1 commit into from

Conversation

hershs
Copy link

@hershs hershs commented Mar 28, 2018

The spark fetcher fails if spark event log is uncompressed. This changes fixes it.

akshayrai
akshayrai suggested changes Mar 29, 2018
View reviewed changes
Copy link
Contributor

@akshayrai akshayrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, can you add some unit tests in SparkUtilsTest

@mateo41 mateo41 mentioned this pull request Apr 20, 2018
Open
@Parth59 Parth59 mentioned this pull request May 24, 2018
Open
@alexlipa91
Copy link

+1

@omicron8
Copy link

It works. Thank you!

AbdelrahmanMosly added a commit to AbdelrahmanMosly/dr-elephant that referenced this pull request Aug 16, 2023
@AbdelrahmanMosly
Support Uncompressed Files
14574c6 
PR found  linkedin#357
@AbdelrahmanMosly AbdelrahmanMosly mentioned this pull request Aug 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayrai akshayrai akshayrai requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hershs @alexlipa91 @omicron8 @akshayrai