Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor deletion #499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor deletion #499

wants to merge 1 commit into from

Conversation

jphui
Copy link
Contributor

@jphui jphui commented Feb 21, 2025

Summary

Get rid of deleteWithReturn() and make returning something a part of the normal delete() call. This will eventually be propagated up to metadata-graph-assets so that a default-parameter-version of delete() can be used for simplicity.

Testing Done

adjusted unit testing

Checklist

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.09%. Comparing base (2de35c0) to head (0cab62a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...n/java/com/linkedin/metadata/dao/BaseLocalDAO.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #499      +/-   ##
============================================
+ Coverage     66.05%   66.09%   +0.04%     
- Complexity     1536     1537       +1     
============================================
  Files           137      137              
  Lines          5927     5923       -4     
  Branches        656      656              
============================================
  Hits           3915     3915              
+ Misses         1733     1730       -3     
+ Partials        279      278       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants