Bug fix for updating configChanged #2900
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is bug in PropertyStoreCleanUpTaskTest. The configChanged variable which we are setting is not getting updated properly. It is due to wrong use of OR operator. This PR fixes this bug.
Testing
Added updated unit tests to ensure the added fix is tested.
Test added :- I have updated DataNodeConfig with multiple disks so that we can check configChanged is updated properly and all replicas are removed from DataNodeConfig when task is running.