An async writable channel implementation that can send the bytes to multiple Readable channels #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2898 +/- ##
============================================
+ Coverage 64.24% 67.35% +3.11%
- Complexity 10398 11441 +1043
============================================
Files 840 863 +23
Lines 71755 73289 +1534
Branches 8611 8815 +204
============================================
+ Hits 46099 49364 +3265
+ Misses 23004 21297 -1707
+ Partials 2652 2628 -24 ☔ View full report in Codecov by Sentry. |
ambry-commons/src/main/java/com/github/ambry/commons/PipedAsyncWritableChannel.java
Outdated
Show resolved
Hide resolved
ambry-commons/src/main/java/com/github/ambry/commons/PipedAsyncWritableChannel.java
Outdated
Show resolved
Hide resolved
Comment on lines
+299
to
+301
| if (exception == null) { | ||
| totalBytesRead.getAndAdd(result); | ||
| } |
There was a problem hiding this comment.
only need to add once for primary.
There was a problem hiding this comment.
I was wondering if totalBytesRead for primary and secondary may not match in case we close secondary early. Due to that, I was thinking to increment it for both. What do you say?
ambry-commons/src/main/java/com/github/ambry/commons/PipedAsyncWritableChannel.java
Outdated
Show resolved
Hide resolved
ambry-commons/src/main/java/com/github/ambry/commons/PipedAsyncWritableChannel.java
Show resolved
Hide resolved
ambry-commons/src/main/java/com/github/ambry/commons/PipedAsyncWritableChannel.java
Outdated
Show resolved
Hide resolved
ambry-commons/src/main/java/com/github/ambry/commons/PipedAsyncWritableChannel.java
Outdated
Show resolved
Hide resolved
ambry-commons/src/main/java/com/github/ambry/commons/PipedAsyncWritableChannel.java
Outdated
Show resolved
Hide resolved
SophieGuo410
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to write uploaded bytes to multiple readers. This is inspired from POC by @justinlin-linkedin here - #2890!