Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuos replication #2896

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Continuos replication #2896

wants to merge 24 commits into from

Conversation

manbearpig1996
Copy link
Contributor

@manbearpig1996 manbearpig1996 commented Sep 18, 2024

This PR contains -

  1. Changing the logic of replication cycle. Currently in a replication cycle, we will create groups and then wait for all
    groups to finish. With this change, we all replica groups will run multiple iterations until any group reaches a predefined limit.
  2. Added logic to terminate cycle, when we are adding/removing replicas or shutting the thread down.
  3. Added tests for group generation, active replication & leader based replication.
  4. If we set limit to 1, then the new logic will work exactly as same as old logic.
  5. New metric for tracking throttled replica count.
  6. logs and converting trackers to string for printing.
  7. Integration of storeKeyConverter drop keys logic to replication logic.
  8. Refactoring of old replicate method to remove redundant statements.
  9. Refactoring of logic of checking replica status to single place.

@manbearpig1996 manbearpig1996 marked this pull request as ready for review September 19, 2024 13:56
@manbearpig1996 manbearpig1996 changed the title Continuos replicate Continuos replication Sep 19, 2024
logger.trace("Thread name: {} Filtered timed out Requests", threadName);

// mark timed out requests to be dropped by network client
Set<Integer> requestsToDrop = responseInfosForTimedOutRequests.stream()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mudit-saxena we have config here too drop request on timeout from replication side too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants