Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated rootpath validation method in zookeeper coordinator #422

Closed
wants to merge 20 commits into from

Conversation

cluyihunter
Copy link

@cluyihunter cluyihunter commented Jul 11, 2018

Validate rootpath with Exists instead of Create to avoid 'zk: not authenticated' error.

Validate rootpath with Exists instead of Create to avoid 'zk: not authenticated' error
@cluyihunter
Copy link
Author

Hi @toddpalino, I tried to solve the issue by digging into the ACL part in samuel/go-zookeeper repo, and found that it does not currently support SASL authentication, where at least a username should be returned in AuthACL (see "https://ihong5.wordpress.com/tag/zookeeper-acl/"). I tried to modify Burrow and pass on SASL credentials using DigestACL but it didn't work. If anyone is interested in fixing the problem I am happy to help & learn. Thanks!

@coveralls
Copy link

coveralls commented Jul 12, 2018

Coverage Status

Coverage increased (+0.07%) to 74.055% when pulling d96b1d1 on cluyihunter:master into 12e681a on linkedin:master.

@cluyihunter
Copy link
Author

My apologies for all the messy small commits. I haven't figured out how to test build and coverage locally as I cannot get past the 'use of internal package is not allowed' restriction in Golang.

@maxtuzz
Copy link
Contributor

maxtuzz commented Jul 31, 2018

@cluyihunter If you move your src over to ~/go/src/github.com/linkedin/Burrow then those errors should go away. Without this, you're technically using the same project as an external dependency which results in errors.

@cluyihunter cluyihunter closed this Aug 3, 2018
@cluyihunter
Copy link
Author

@maxtuzz Yes I have github.com/linkedin/Burrow in src under my gopath, but still the error persists whenever I try testing (use of internal package is not allowed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants