-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Short date culture fix #349
Short date culture fix #349
Conversation
Previously was hardcoded to .ToString("dd/MM/yyyy") which could be confusing for some users.
Previously was hardcoded to .ToString("dd/MM/yyyy") which could be confusing for some users.
Previously was hardcoded to .ToString("dd/MM/yyyy") which could be confusing for some users.
Thanks for the PR @digitaldirk ! Two small things:
|
I will make some more changes and sorry I should have been more proactive on the tests (quickly did this PR on web) |
Nahhh don’t worry - given that all tests are green, they had some implicit assumptions or behavior. |
ShouldPublishScheduledBlogPosts failed but that also fails on a fresh pull of master branch. Think I'm all done :) |
|
Thanks for your efforts - I will merge the PR |
Previously were hardcoded to .ToString("dd/MM/yyyy") which could be confusing for some users.
For example: currently a date would show:
02/09/2024
, but now it would show as9/2/2024
for theen-US
culture