Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Azure Ad and other OpenID connect based auth providers #256

Merged
merged 9 commits into from
Aug 2, 2023
Merged

Added support for Azure Ad and other OpenID connect based auth providers #256

merged 9 commits into from
Aug 2, 2023

Conversation

manishtiwari25
Copy link
Contributor

Removed the tight coupling with auth0 and made it more common so we can use other OpenID connect based auth providers.
I am using Azure active directory so I added these.

@linkdotnet
Copy link
Owner

Very good point! I will have a look tonight. Thanks @manishtiwari25

@linkdotnet
Copy link
Owner

I have a few points, but looks good so far!

@linkdotnet
Copy link
Owner

linkdotnet commented Aug 2, 2023 •
edited
Loading

Good job - there is one last thing: There is a test for the AppConfigurationFactory that should be extended.

EDIT: Forgot what I said - GitHub showed me only some of your new commits - good job!

@linkdotnet linkdotnet merged commit 212939b into linkdotnet:master Aug 2, 2023
1 check passed
@linkdotnet
Copy link
Owner

Thanks again @manishtiwari25 - I am thinking of removing the backward compatibility fo Auth0 if the config is not given.
I guess am fine breaking things in the code to have a cleaner code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linkdotnet linkdotnet linkdotnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manishtiwari25 @linkdotnet