Simplified ReadingIndicator and remove exceptions

linkdotnet · Apr 11, 2024 · 86fd9a8 · 86fd9a8
1 parent 2cdf5ca
commit 86fd9a8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 19 deletions.
diff --git a/src/LinkDotNet.Blog.Web/Features/ShowBlogPost/Components/ReadingIndicator.razor b/src/LinkDotNet.Blog.Web/Features/ShowBlogPost/Components/ReadingIndicator.razor
@@ -1,5 +1,4 @@
 @inject IJSRuntime JSRuntime
-@implements IAsyncDisposable
 
 <div class="progress-container" @ref="progressContainer">
     <svg class="progress-circle" viewBox="0 0 36 36">
@@ -22,9 +21,4 @@
 			await JSRuntime.InvokeVoidAsync("initCircularReadingProgress", ContainerCssSelector, progressContainer);
 		}
 	}
-
-	public async ValueTask DisposeAsync()
-	{
-		await JSRuntime.InvokeVoidAsync("destroyCircularReadingProgress");
-	}
 }
diff --git a/src/LinkDotNet.Blog.Web/Features/ShowBlogPost/Components/ReadingIndicator.razor.js b/src/LinkDotNet.Blog.Web/Features/ShowBlogPost/Components/ReadingIndicator.razor.js
@@ -22,13 +22,11 @@ function hideProgressIndicator(progressContainer) {
     }, 500);
 }
 
-function onScroll(onScroll) {
-    if (!rafId) {
-        rafId = requestAnimationFrame(onScroll);
-    }
-}
-
 window.initCircularReadingProgress = (parentContainer, progressContainer) => {
+		if (window.circularProgressScrollListenerAdded) {
+			return;
+		}
+
     const progressBar = document.getElementById('progressBar');
 
     const onScroll = () => {
@@ -50,11 +48,5 @@ window.initCircularReadingProgress = (parentContainer, progressContainer) => {
         rafId = null;
     };
 
-    window.addEventListener('scroll', onScroll) ;
+    window.addEventListener('scroll', onScroll);
 };
-
-window.destroyCircularReadingProgress = () => {
-    window.removeEventListener('scroll', onScroll);
-    clearTimeout(progressTimeout);
-    cancelAnimationFrame(rafId);
-}