refactor: API design

linkdotnet · Mar 28, 2024 · 150dc0b · 150dc0b
1 parent a05a5c3
commit 150dc0b
Showing 1 changed file with 8 additions and 11 deletions.
diff --git a/src/LinkDotNet.Blog.Web/Features/TransformBlogPostRecordsJob.cs b/src/LinkDotNet.Blog.Web/Features/TransformBlogPostRecordsJob.cs
@@ -53,21 +53,18 @@ public async Task RunAsync(JobExecutionContext context, CancellationToken token)
         }
     }
 
-    private static IEnumerable<BlogPostRecord> GetBlogPostRecords(
+    private static BlogPostRecord[] GetBlogPostRecords(
         IEnumerable<BlogPost> blogPosts,
         IEnumerable<UserRecord> userRecords)
     {
         var clicksPerDay = GetClicksPerDay(userRecords);
 
-        return from blogPost in blogPosts
-               from date in clicksPerDay.Keys.Where(k => k.blogPostId == blogPost.Id)
-               select new BlogPostRecord
-               {
-                   Id = blogPost.Id,
-                   BlogPostId = blogPost.Id,
-                   DateClicked = date.date,
-                   Clicks = clicksPerDay[date],
-               };
+        return blogPosts
+            .SelectMany(blogPost => clicksPerDay.Keys.Where(k => k.blogPostId == blogPost.Id),
+                (blogPost, date) => new BlogPostRecord
+                {
+                    Id = blogPost.Id, BlogPostId = blogPost.Id, DateClicked = date.date, Clicks = clicksPerDay[date],
+                }).ToArray();
     }
 
     private static Dictionary<(string blogPostId, DateOnly date), int> GetClicksPerDay(IEnumerable<UserRecord> userRecords)
@@ -110,7 +107,7 @@ private async Task TransformRecordsAsync()
         var userRecords = await userRecordRepository.GetAllAsync(
             filter: r => r.UrlClicked.StartsWith("blogPost/"));
 
-        var newBlogPostRecords = GetBlogPostRecords(blogPosts, userRecords).ToArray();
+        var newBlogPostRecords = GetBlogPostRecords(blogPosts, userRecords);
         if (newBlogPostRecords.Length == 0)
         {
             return;