[testnet] Fix missing committee blobs handling. #4986
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afck
changed the title
deuszx
reviewed
Nov 19, 2025
deuszx
reviewed
Nov 19, 2025
| builder | ||
| }; | ||
|
|
||
| runtime.thread_stack_size(4 << 20); |
deuszx
reviewed
Nov 19, 2025
Comment on lines
+824
to
+829
| let committee_blob = self | ||
| .context() | ||
| .extra() | ||
| .get_blob(blob_id) | ||
| .await? | ||
| .ok_or(ExecutionError::BlobsNotFound(vec![blob_id]))?; |
Contributor
There was a problem hiding this comment.
Probably not introduced in this PR but maybe we can return all missing committee blobs at once? Then the client can choose whether to udpate one-by-one or in a single message.
Contributor
Author
|
Closing this for now. I will apply your comments on #4978 and backport once it's merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#4978 revealed that the client fails to send the admin chain to validators that are missing a committee in some cases.
Proposal
Remove
committees_forfrom storage. ReturnBlobsNotFoundandEventsNotFoundinstead ofViewErrors.Also remove some redundant code, and check height before epoch when handling a validated block.
I got stack overflows in some cases, so I also doubled the client's Tokio thread stack size.
Test Plan
CI
#4978 failed without this.
Release Plan
Links