Allow running a faucet from linera net up #3115
Merged
+153
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afck
approved these changes
Jan 13, 2025
Comment on lines
323
to
328
| let chain_ids = client | ||
| .find_owned_chains() | ||
| .expect("Cannot retrieve chains from linera wallet"); | ||
| let chain_id = chain_ids.get(faucet_chain as usize).expect( | ||
| "Was expecting a number `faucet_chain` in the range `0..=num_other_initial_chains`", | ||
| ); |
There was a problem hiding this comment.
Why not ChainID::root(faucet_chain)? That's closer to what the documentation says (the Nth root chain), so it would still be true if we changed the order in which chains appeared in the wallet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
First step in addressing #2890
Proposal
find_owned_chainsout of the code inClientWrapper::drop()--with-faucet-chain Ntolinera net upas well as--faucet-portand--faucet-amountThe only caveat is that
Ncannot be a chain-id (since we wouldn't know what to write) so we use the index amongst root chains (typically 1 for the first non-admin initial chain).Test Plan
CI