Added keepalive timout so that connections are not dropped. #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twey
approved these changes
Oct 31, 2024
christos-h
force-pushed
the
grpc-client-keep-alive
branch
from
52bead2 to
b298a84
Compare
ma2bd
reviewed
Oct 31, 2024
| @@ -42,6 +43,7 @@ cfg_if::cfg_if! { | |||
| if let Some(timeout) = options.timeout { | |||
| endpoint = endpoint.timeout(timeout); | |||
| } | |||
| endpoint = endpoint.keep_alive_timeout(Duration::from_millis(KEEPALIVE_TIME_MS)); | |||
There was a problem hiding this comment.
Can we make it another option?
There was a problem hiding this comment.
Seems like we could copy paste the code for options.timeout
There was a problem hiding this comment.
This is intentionally not an option. The reason is that this should be negotiated on a per-validator basis. The reason is that different ingresses have different timeouts.
However after further discussion with @Twey , we think a better implementation may be to have the keepalive originate from the server - hence why this is still a draft.
The server-side option will be configurable.
christos-h
force-pushed
the
grpc-client-keep-alive
branch
2 times, most recently
from
c91b697 to
ff122c8
Compare
christos-h
force-pushed
the
grpc-client-keep-alive
branch
from
ff122c8 to
c62b1f4
Compare
christos-h
force-pushed
the
grpc-client-keep-alive
branch
from
c62b1f4 to
62a297a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Connections with validators are dropped after 1 minute due to connections being inactive.
Proposal
Use gRPC keep-alive to send ping frames every 40 seconds to keep the connections alive.
This is hard-coded for now. Future improvement involves client <> server negotation of the keepalive timeout value per-validator.
Test Plan
Manually tested. CI will catch regressions.
Release Plan
devnetbranch, thentestnetbranch, thenLinks
https://grpc.io/docs/guides/keepalive/#keepalive-configuration-specification