parley: drop Source OpenType settings, simplify settings types#506
Open
waywardmonkeys wants to merge 1 commit intolinebender:mainfrom
Open
parley: drop Source OpenType settings, simplify settings types#506waywardmonkeys wants to merge 1 commit intolinebender:mainfrom
Source OpenType settings, simplify settings types#506waywardmonkeys wants to merge 1 commit intolinebender:mainfrom
Conversation
* Remove `Source` variants and `From<&str>` for `FontFeatures` / `FontVariations`; Parley no longer parses CSS-like OpenType strings during resolution.
* Add a unit test demonstrating `text_primitives::{FontFeature, FontVariation}::parse_css_list` and passing the typed lists into Parley.
* Replace the now-single-variant enums with newtype wrappers around `Cow<[FontFeature]>` / `Cow<[FontVariation]>` for simpler, slice-like ergonomics.
* Add `StyleProperty` conversions from `&[FontFeature]`, `&[FontVariation]`, and `&[T; N]`; simplify resolution helpers to operate on slices and update tests.
Collaborator
|
To me, this breaks the nice symmetry with |
taj-p
reviewed
Feb 13, 2026
Contributor
taj-p
left a comment
taj-p
left a comment
There was a problem hiding this comment.
I think this might be OBE? If not, please re-request after addressing Chad's comment and I can take a look 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sourcevariants andFrom<&str>forFontFeatures/FontVariations; Parley no longer parses CSS-like OpenType strings during resolution.text_primitives::{FontFeature, FontVariation}::parse_css_listand passing the typed lists into Parley.Cow<[FontFeature]>/Cow<[FontVariation]>for simpler, slice-like ergonomics.StylePropertyconversions from&[FontFeature],&[FontVariation], and&[T; N]; simplify resolution helpers to operate on slices and update tests.