Fixing Cluster Info + adding cluster layout snapshots #402
+459
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taj-p
commented
Aug 24, 2025
|
|
||
| /// Returns the text length of the cluster in bytes. | ||
| #[cfg(test)] | ||
| pub(crate) fn text_len(&self) -> u8 { |
There was a problem hiding this comment.
I'd really like to test this in check_cluster_snapshot, so I've exposed it for tests only.
taj-p
commented
Aug 24, 2025
| @@ -100,6 +99,11 @@ impl ClusterInfo { | |||
| pub(crate) fn is_whitespace(&self) -> bool { | |||
| self.source_char.is_whitespace() | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
| pub(crate) fn source_char(&self) -> char { | |||
There was a problem hiding this comment.
I'd really like to test this in check_cluster_snapshot, so I've exposed it for tests only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
I noticed that, although my manual tests were passing, the
source_charused for a given cluster wasn't always correct. I think we were lucky (if that's the right word) that characters that contribute to a ligature typically mimic the properties of other characters in that ligature.This PR corrects those mistakes and adds more tests and documentation.
check_cluster_snapshotI think it's pretty tricky to ensure that returned clusters are correct so I've added a new snapshot type enabled via
check_cluster_snapshotwhich tries to visualise cluster information (and ensure correcttext_len). This should makepush_runmore resilient to regressions and maintenance easier.