Skip to content

Use a range to store deferred boxes during shaping #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use a range to store deferred boxes during shaping #401

wants to merge 1 commit into from
+11 −5

Conversation

nicoburns
Copy link
Contributor

Objective

  • Eliminate an unneccesary allocation
  • Very slightly reduce memory usage

Changes made

Use a range instead of a vec to store "deferred boxes" during the shaping process.

Context

This came up as review feedback during the initial implementation of inline boxes but was deferred (ha) as a followup

@nicoburns nicoburns requested a review from taj-p August 22, 2025 16:22
taj-p
taj-p approved these changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@taj-p taj-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always great to save an allocation!

was deferred (ha) as a followup

😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taj-p taj-p taj-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicoburns @taj-p