Fix no_std compilation in fontique.
#158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waywardmonkeys
approved these changes
Nov 5, 2024
| core-text = "20.1.0" | ||
| core-foundation = "0.9.4" | ||
| objc2 = { version = "0.5.2" } | ||
| objc2-foundation = { version = "0.2.2", features = ["NSArray", "NSEnumerator", "NSPathUtilities", "NSString"] } | ||
|
|
||
| [target.'cfg(not(any(target_vendor="apple", target_family="windows")))'.dependencies] | ||
| [target.'cfg(any(target_os = "linux", target_os = "android"))'.dependencies] |
There was a problem hiding this comment.
We don't test it, but would this code path be used on FreeBSD or some of the other target_os things?
One that might be more relevant would be Open Harmony, not sure what they're doing for things like this... (@nicoburns ?)
There was a problem hiding this comment.
No it wouldn't be used because the code is:
#[cfg(all(feature = "system", target_os = "linux"))]
#[path = "fontconfig/mod.rs"]
mod system;
#[cfg(all(feature = "system", target_os = "android"))]
#[path = "android.rs"]
mod system;If the code gets support for additional OSes, then the dependencies should as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following command now passes:
The key was removing the use of
not(any(target_vendor="apple", target_family="windows"))to includestdusing dependencies, which triggers withx86_64-unknown-none.I also synced the dependency conditionals with what the code expects.
This is progress towards #86.