Introduce the notion of a default SessionProtocol
#6128
+884
−53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It has been suggested that
SessionProtocol.UNDEFINED
be avoided at #6060 (comment), and a defaultSessionProtocol
for clients is introduced.A client can now be created without the user explicitly providing a
SessionProtocol
. By defaultSessionProtocol.HTTP
will be used. For clients that are created with a String, users will be able to use the defaultSessionProtocol
via scheme relative URIs as defined in the following rfc.One point to note is that
RequestTarget
may be parsed different depending on whether the input is a path, or a uri.In the context of a path,
//my-path
is a completely valid path whereas in the context of a URI,//my-path
will be a uri with authoritymy-path
.In order to address this,
DefaultRequestTarget#forClientPath
has been introduced.Possibly breaking behavior is that requests cannot be made using a path starting with
//
.Modifications:
SessionProtocol
as defined bySessionProtocolUtil#defaultSessionProtocol
.RequestTarget#forClient
RequestTarget#forClientPath
and modified existing callers to use the new API when applicableResult:
SessionProtocol