Set Eureka InstanceInfo to endpoint attribute #6069
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: line#6056 Motivation: Users might want to use the metadata from the Eureka `InstanceInfo` but currently, there's no way to retrieve it. Modifications: - Add a helper class to hide the implementation detail. - Set the `InstanceInfo` to the `Endpoint` as an attribute. Result: - Closes line#6056 - Now users can retrieve it.
Ivan-Montes
requested review from
ikhoon,
jrhee17,
minwoox and
trustin
as code owners
|
|
minwoox
reviewed
Jan 14, 2025
| @@ -399,6 +400,24 @@ public List<Endpoint> apply(byte[] content) { | |||
| } | |||
| } | |||
|
|
|||
| private static final class EurekaInstanceInfoUtil { | |||
There was a problem hiding this comment.
Let's:
- Remove this class because users cannot access this class to retrieve
InstanceInfo - Move
com.linecorp.armeria.internal.common.eureka.InstanceInfotocom.linecorp.armeria.common.eureka.InstanceInfo - Move the methods to the
InstanceInfoclass - Add a test to verify that users can retrieve the
InstanceInfo
There was a problem hiding this comment.
Okay, thanks for the steps. I will work on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #6056
Motivation:
Users might want to use the metadata from the Eureka
InstanceInfobut currently, there's no way to retrieve it.Modifications:
InstanceInfoto theEndpointas an attribute.Result: