Prevent Execution of Delayed Tasks for Cancelled gRPC Requests

[minwoox]

Motivation:
When blockingTaskExecutor is used in a gRPC service, tasks handling gRPC requests are queued if the executor is busy with heavy blocking jobs.

armeria/grpc/src/main/java/com/linecorp/armeria/internal/server/grpc/AbstractServerCall.java

Line 363 in 0960d09

blockingExecutor.execute(() -> invokeOnMessage(request, endOfStream));

If these tasks are delayed for too long, the corresponding gRPC requests may time out and get cancelled. Despite the cancellation, the queued tasks are still executed once the executor becomes available, leading to unnecessary processing.

armeria/grpc/src/main/java/com/linecorp/armeria/internal/server/grpc/AbstractServerCall.java

Lines 394 to 404 in 0960d09

	private void invokeOnMessage(I request, boolean halfClose) {
	try (SafeCloseable ignored = ctx.push()) {
	assert listener != null;
	listener.onMessage(request);
	if (halfClose) {
	listener.onHalfClose();
	}
	} catch (Throwable cause) {
	close(cause);
	}
	}

Modifications:

• Updated AbstractServerCall.invokeOnMessage() to check if the request is cancelled before calling listener.onMessage.

Result:

• Prevents execution of delayed tasks for gRPC requests that have already been cancelled.

Co-authored-by: szymon.habrainski [email protected]

[github-actions]

🔍 Build Scan® (commit: ae9601a)

Job name	Status	Build Scan®
build-ubicloud-standard-8-jdk-8	✅	https://ge.armeria.dev/s/7kcyuxozgbsv6
build-ubicloud-standard-8-jdk-21-snapshot-blockhound	✅	https://ge.armeria.dev/s/twlaaissur6vg
build-ubicloud-standard-8-jdk-17-min-java-17-coverage	✅	https://ge.armeria.dev/s/u5ha2fml2moha
build-ubicloud-standard-8-jdk-17-min-java-11	❌ (failure)	https://ge.armeria.dev/s/mameqpmvopktk
build-ubicloud-standard-8-jdk-17-leak	✅	https://ge.armeria.dev/s/2c4uor2vg2iha
build-ubicloud-standard-8-jdk-11	✅	https://ge.armeria.dev/s/air6jenozqn56
build-macos-latest-jdk-21	✅	https://ge.armeria.dev/s/gflti45byc62e