Use ubicloud-standard-16 to run CI builds #6065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get more benefits from parallelism.
minwoox
reviewed
Jan 10, 2025
.github/workflows/actions_build.yml
Outdated
| @@ -96,7 +96,7 @@ jobs: | |||
| - name: Build with Gradle (Shading only) | |||
| run: | | |||
| ./gradlew --no-daemon --stacktrace shadedJar shadedTestJar trimShadedJar \ | |||
| ${{ startsWith(matrix.on, 'ubicloud') && '--max-workers=8' || '--max-workers=2' }} --parallel \ | |||
| ${{ startsWith(matrix.on, 'ubicloud') && '--max-workers=12' || '--max-workers=2' }} --parallel \ | |||
There was a problem hiding this comment.
How about just keeping it as 8 even though there are 16 vCPU?
I think 8 workers are enough and we changed this machine due to the memory issue. 😉
There was a problem hiding this comment.
I thought we could reduce the cost a bit, but let's keep it at 8.
|
The running time was reduced by about 20% with ubicloud-standard-16. |
jrhee17
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get more benefits from parallelism.