Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test ContextCancellationTest #5869

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

jrhee17
Copy link
Contributor

@jrhee17 jrhee17 commented Aug 12, 2024

Motivation:

Let me just remove the validation like @minwoox suggested

Modifications:

  • Removed the validation on request context.

Result:

@ikhoon ikhoon added this to the 1.30.0 milestone Aug 12, 2024
@ikhoon ikhoon added the cleanup label Aug 12, 2024
@ikhoon
Copy link
Contributor

ikhoon commented Aug 12, 2024

@jrhee17
Copy link
Contributor Author

jrhee17 commented Aug 12, 2024

The CI status is unstable. I will postpone the release process until this issue is fixed.

Sorry about this, will fix ASAP

@ikhoon
Copy link
Contributor

ikhoon commented Aug 12, 2024

No worries. Take your time. 😉

@jrhee17 jrhee17 marked this pull request as ready for review August 12, 2024 09:39
@jrhee17
Copy link
Contributor Author

jrhee17 commented Aug 12, 2024

Ready for review

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♂️🙇‍♂️

@ikhoon ikhoon merged commit 4f17989 into line:main Aug 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants