-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test ContextCancellationTest
#5869
Conversation
The CI status is unstable. I will postpone the release process until this issue is fixed. |
Sorry about this, will fix ASAP |
No worries. Take your time. 😉 |
Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇♂️🙇♂️
Motivation:
Let me just remove the validation like @minwoox suggested
Modifications:
Result:
com.linecorp.armeria.client.ContextCancellationTest.cancel_beforeWriteFinished(TestInfo)
#5868