Fix flaky ServerMetrics tests
#5812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikhoon
pushed a commit
to ikhoon/armeria
that referenced
this pull request
Jul 19, 2024
Motivation: - https://ge.armeria.dev/s/4nbxggtjahu5w/tests/task/:core:shadedTest/details/com.linecorp.armeria.server.ServerMetricsTest/checkWhenOk(SessionProtocol%2C%20long%2C%20long)%5B1%5D?top-execution=1 - https://ge.armeria.dev/s/ymlrbcecdkwz4/tests/task/:core:shadedTest/details/com.linecorp.armeria.server.ServerMetricsTest/checkWhenRequestTimeout(SessionProtocol%2C%20long%2C%20long)%5B1%5D?top-execution=1 The above flaky tests are failing relatively often: https://ge.armeria.dev/scans/tests?search.timeZoneId=Asia%2FSeoul&tests.container=com.linecorp.armeria.server.ServerMetricsTest# Cancelling the request doesn't guarantee that the server-side request is closed immediately. Modifications: - Added an `await` condition which waits until the active request in server-side has indeed been closed Result: - Less flaky tests regarding `ServerMetrics` <!-- Visit this URL to learn more about how to write a pull request description: https://armeria.dev/community/developer-guide#how-to-write-pull-request-description -->
ikhoon
pushed a commit
that referenced
this pull request
Jul 26, 2024
Motivation: - https://ge.armeria.dev/s/4nbxggtjahu5w/tests/task/:core:shadedTest/details/com.linecorp.armeria.server.ServerMetricsTest/checkWhenOk(SessionProtocol%2C%20long%2C%20long)%5B1%5D?top-execution=1 - https://ge.armeria.dev/s/ymlrbcecdkwz4/tests/task/:core:shadedTest/details/com.linecorp.armeria.server.ServerMetricsTest/checkWhenRequestTimeout(SessionProtocol%2C%20long%2C%20long)%5B1%5D?top-execution=1 The above flaky tests are failing relatively often: https://ge.armeria.dev/scans/tests?search.timeZoneId=Asia%2FSeoul&tests.container=com.linecorp.armeria.server.ServerMetricsTest# Cancelling the request doesn't guarantee that the server-side request is closed immediately. Modifications: - Added an `await` condition which waits until the active request in server-side has indeed been closed Result: - Less flaky tests regarding `ServerMetrics` <!-- Visit this URL to learn more about how to write a pull request description: https://armeria.dev/community/developer-guide#how-to-write-pull-request-description -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The above flaky tests are failing relatively often: https://ge.armeria.dev/scans/tests?search.timeZoneId=Asia%2FSeoul&tests.container=com.linecorp.armeria.server.ServerMetricsTest#
Cancelling the request doesn't guarantee that the server-side request is closed immediately.
Modifications:
awaitcondition which waits until the active request in server-side has indeed been closedResult:
ServerMetrics