Skip to content

Commit

Permalink
Fix flaky InitiateConnectionShutdownTest (#5944)
Browse files Browse the repository at this point in the history
Motivation: 

- #5743
- #5333
- #3982

I'm not sure this change could resolve the flakiness but it would be
worthwhile to explicitly wait for a connection to close before checking
invocations.

Modifications:

- Wait for `clientChannel` to be closed.

Result:

- Closes #5743
- Closes #5333
- Closes #3982

I will reopen the issues if the flaky is reproduced.
  • Loading branch information
ikhoon authored Oct 18, 2024
1 parent 585ddb9 commit 8a6ae51
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ private void makeHttp2Request(String path) throws Exception {
});
await().untilTrue(finished);
await().untilTrue(connectionClosed);
clientChannel.closeFuture().syncUninterruptibly();
}

@BeforeEach
Expand Down

0 comments on commit 8a6ae51

Please sign in to comment.