Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to execute one test multiple times with different parameters #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PetrDlouhy
Copy link

I wanted to perform the check_cache test on all of my caches so I modified the code to allow set/array in ALIVE_CHECKS settings.

@PetrDlouhy
Copy link
Author

@ipmb Could you please check this PR?

@ipmb
Copy link
Member

ipmb commented Mar 8, 2024

I think the list of tuples format should be the default. We can keep dict support as a legacy/deprecated option.

@PetrDlouhy
Copy link
Author

@ipmb Thanks for the comment. I have transformed the code, so that list of tuples is default. Dict now throws deprecated warning.

I have also added test for the old behavior. I had to move ALIVE_CHECKS variable to the function, otherwise the override_settings would not work.

All tests should pass when you pull #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants