Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-3427 [MU] Print draft #3434

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Jan 15, 2025

Issue

#3427

Resolved

Screen.Recording.2025-01-16.at.11.22.56.online-video-cutter.com.mp4

Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3434.

@chibenwa
Copy link
Member

chibenwa commented Jan 15, 2025

Can we collapse side features of the composer in a side menu (...) the way Gmail does?

Making print, read receipt, embedded code and other future side feature one click away is IMO acceptable and would avoid polluting the already very loaded composer space.

Thoughts?

@chibenwa
Copy link
Member

image

@dab246
Copy link
Member Author

dab246 commented Jan 16, 2025

Can we collapse side features of the composer in a side menu (...) the way Gmail does?

Of course. We can do it like Gmail does.

Making print, read receipt, embedded code and other future side feature one click away is IMO acceptable and would avoid polluting the already very loaded composer space.

Thoughts?

IMO, that's right. With such collapse side features, it will be suitable to add new options later. We will implement it right away in this PR.

Screen.Recording.2025-01-16.at.11.22.56.online-video-cutter.com.mp4

@chibenwa
Copy link
Member

Huge thanks, it looks gorgeous.

How does this looks like on mobile?

@dab246
Copy link
Member Author

dab246 commented Jan 16, 2025

Huge thanks, it looks gorgeous.

How does this looks like on mobile?

Like the email print feature, we currently only support print draft on web browsers. For mobile, we will research and develop in another PR.

@chibenwa
Copy link
Member

I speak more about the ... button.

Not printing on mobile seems indeed the right thing to do!

@hoangdat
Copy link
Member

hoangdat commented Jan 17, 2025

  • click outside (to email editor), context menu can not close

image

Sorry, something went wrong.

@hoangdat
Copy link
Member

hoangdat commented Jan 17, 2025

  • subject was not in print
Screen.Recording.2025-01-17.at.13.54.22.mov

Sorry, something went wrong.

@dab246
Copy link
Member Author

dab246 commented Jan 17, 2025

  • click outside (to email editor), context menu can not close

  • subject was not in print

Done.

Screen.Recording.2025-01-17.at.18.25.50.mov

Sorry, something went wrong.

@dab246 dab246 requested a review from hoangdat January 17, 2025 11:33
@dab246 dab246 requested a review from hoangdat January 20, 2025 11:50
@dab246 dab246 force-pushed the enhancement/tf-3427-mu-print-draft branch from c1e4817 to 88e03fb Compare January 20, 2025 12:45
@hoangdat
Copy link
Member

hoangdat commented Jan 21, 2025

  • remove print action in composer in mobile browser app

Sorry, something went wrong.

@dab246 dab246 force-pushed the enhancement/tf-3427-mu-print-draft branch from 88e03fb to 71badf0 Compare January 21, 2025 04:22
@dab246
Copy link
Member Author

dab246 commented Jan 21, 2025

  • remove print action in composer in mobile browser app

Done

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
aduh95 Antoine du Hamel
Signed-off-by: dab246 <[email protected]>
@dab246 dab246 force-pushed the enhancement/tf-3427-mu-print-draft branch from 71badf0 to 1662bc7 Compare January 21, 2025 11:01
@hoangdat hoangdat merged commit 94c15fc into maintenance-v0.14.2 Jan 21, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants