New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-3416 Render EML attachment #3425

Merged

hoangdat merged 12 commits into maintenance-v0.14.2 from improvement/tf-3416-render-eml-attachment

Jan 20, 2025

Member

dab246 commented Jan 13, 2025 •

edited

Loading

Issue

Dependencies

Need merged: Implement Email/parse method jmap-dart-client#104

Resolved

Web:

Screen.Recording.2025-01-13.at.15.54.43.mov

Mobile:

demo.webm

dab246 requested a review from hoangdat

January 13, 2025 09:57

dab246 temporarily deployed to PR-3425

January 13, 2025 09:57

— with

GitHub Actions Inactive

dab246 requested a review from tddang-linagora

January 13, 2025 09:57

Member

chibenwa commented Jan 13, 2025

That is awesome!

Thanks you.

Member

chibenwa commented Jan 13, 2025

Question: how does it looks like on mobile?

github-actions bot commented Jan 13, 2025

This PR has been deployed to https://linagora.github.io/tmail-flutter/3425.

dab246 temporarily deployed to PR-3425

January 14, 2025 02:49

— with

GitHub Actions Inactive

Member Author

dab246 commented Jan 14, 2025 •

edited

Loading

Question: how does it looks like on mobile?

Please see in description on top: @chibenwa

Screenshot 2025-01-14 at 09 55 15

dab246 added the customer label

dab246 temporarily deployed to PR-3425

January 14, 2025 05:58

— with

GitHub Actions Inactive

hoangdat reviewed

View reviewed changes

core/lib/presentation/extensions/media_type_extension.dart Show resolved Hide resolved

hoangdat reviewed

View reviewed changes

lib/main.dart Show resolved Hide resolved

hoangdat reviewed

View reviewed changes

lib/features/email/data/repository/email_repository_impl.dart Show resolved Hide resolved

hoangdat reviewed

View reviewed changes

lib/features/email/domain/usecases/preview_email_from_eml_file_interactor.dart Show resolved Hide resolved

hoangdat reviewed

View reviewed changes

lib/features/email/domain/usecases/preview_email_from_eml_file_interactor.dart Show resolved Hide resolved

hoangdat reviewed

View reviewed changes

lib/features/email_previewer/email_previewer_controller.dart Show resolved Hide resolved

hoangdat reviewed

View reviewed changes

lib/features/email_previewer/email_previewer_controller.dart Show resolved Hide resolved

dab246 requested a review from hoangdat

January 17, 2025 11:42

dab246 added 10 commits

January 20, 2025 10:27


          TF-3416 Implement parse email by blob id interactor

d7e4089


          TF-3416 Implement preview EML attachment

c255e85


          TF-3416 Persist preview EML content when make reload page action

b2e36a0


          TF-3416 Handle open EML attachment in EML previewer

9a0004d


          TF-3416 Handle preview EML attachment on mobile

23c57fc


          TF-3416 Handle mailto link in EML previewer on mobile

de0ce02


          TF-3416 Handle open EML attachment in EML previewer on mobile

1a5bf87


          TF-3416 Handle download attachment in EML previewer on mobile

7eb695c


          TF-3416 Handle download attachment in EML previewer on web

4258ce9


          TF-3416 Update jmap-dart-client dependency

9be2be9

dab246 force-pushed the improvement/tf-3416-render-eml-attachment branch from d228103 to 9be2be9 Compare

January 20, 2025 03:27

dab246 had a problem deploying to PR-3425

January 20, 2025 03:27

— with

GitHub Actions Failure


          fixup! TF-3416 Update jmap-dart-client dependency

eea175d

dab246 temporarily deployed to PR-3425

January 20, 2025 07:14

— with

GitHub Actions Inactive


          TF-3416 Update avatar by sender

2501fc2

dab246 deployed to PR-3425

January 20, 2025 09:47

— with

GitHub Actions View deployment

Member Author

dab246 commented Jan 20, 2025

Update avatar by sender name

Screenshot 2025-01-20 at 16 43 15

hoangdat had a problem deploying to prod

January 20, 2025 11:33

— with

GitHub Actions Error

hoangdat had a problem deploying to prod

January 20, 2025 11:33

— with

GitHub Actions Error

hoangdat temporarily deployed to prod

January 20, 2025 11:33

— with

GitHub Actions Inactive

hoangdat approved these changes

View reviewed changes

hoangdat merged commit 71484d6 into maintenance-v0.14.2

24 of 26 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels